chore: align with community Elixir style guide#130
Merged
Conversation
Re-enable Credo's Readability.AliasOrder and Readability.ModuleDoc checks (previously disabled), then fix the violations they surface. - Sort `alias` groups alphabetically across lib/ and test/ - Add `@moduledoc false` to nested helper modules in test/support/ - Move `:hardfork` to the atom list in `EEVM.Config` defstruct so no field is given an explicit `nil` default Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readability.AliasOrderandReadability.ModuleDocchecks (previously disabled)aliasgroups alphabetically across lib/ and test/ (~30 files)@moduledoc falseto 10 nested helper modules in test/support/EEVM.Config(no field gets an explicitnildefault)Aligns the codebase with the community Elixir style guide.
Test plan
mix credo --strictclean (was 49 issues, now 0)mix test— 4 doctests, 613 tests, 0 failuresmix compile --warnings-as-errorscleanmix docsbuilds without warnings🤖 Generated with Claude Code