refactor: drive opcode dispatch from the Registry#131
Merged
Conversation
Replace the hand-maintained case-clause dispatch in `EEVM.Interpreter` with a single registry lookup. Each opcode entry in `EEVM.Interpreter.Instructions.Registry` now carries `:module` (the implementing module) and an optional `:state_mutating` flag. `execute_opcode/2` becomes: - if the opcode is state-mutating and the frame is static → halt :reverted - if the registry has a module → delegate `execute(opcode, state)` - otherwise → halt :invalid One source of truth for opcode metadata + dispatch, fewer places to forget when adding a new opcode, and the static-context check is expressed declaratively instead of as five separate guard clauses. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ExDoc treats backtick-wrapped `Mod.fun/arity` as an autolink target and warns when it points at a private function. Rephrase the Registry moduledoc to reference `EEVM.Interpreter` (the module) instead. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EEVM.Interpreter.Instructions.Registrynow carries:module(the implementing module) and an optional:state_mutatingflag.EEVM.Interpreter.execute_opcode/2is reduced from a ~60-line case table to a single registry lookup::revertedexecute(opcode, state):invalidTest plan
mix test— 4 doctests, 613 tests, 0 failures (no behavior change)mix credo --strictcleanmix format --check-formattedcleanmix compile --warnings-as-errorsclean🤖 Generated with Claude Code