refactor: unify parent_hash representation as binary (#128)#134
Merged
Conversation
Block headers already canonicalised parent_hash as a 32-byte binary, but BlockHashes.commit/3 took a non_neg_integer, forcing a parent_hash_to_int shim in BlockchainTestRunner that handled nil / binary / integer. Switch commit/3 to accept a 32-byte binary directly (the calldata is already encoded as 32 bytes), pass header.parent_hash through unchanged, and delete the shim. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Block.Header.parent_hashwas already canonicalised as a 32-bytebinary(), butBlockHashes.commit/3took anon_neg_integer()— forcing aparent_hash_to_intshim inBlockchainTestRunnerthat handlednil/binary/integer.commit/3to accept the 32-byte binary directly (the calldata was already encoded as 32 bytes), passheader.parent_hashthrough unchanged, and delete the shim.Test plan
mix compilecleanmix credo --strictcleanmix test— 4 doctests, 613 tests, 0 failuresmix test test/system_contracts/block_hashes_test.exs— 11 tests, 0 failuresmix test test/blockchain_test_test.exs— 2 tests, 0 failures🤖 Generated with Claude Code