Open
Conversation
Member
|
Thanks! I'll wait for a 3rd party approbation. I keep merging Psalm PRs on this project, and it seems half of them breaks something for someone ^^ I don't know enough Psalm to validate the annotation changes honestly. |
simPod
commented
Aug 3, 2021
Contributor
Author
simPod
left a comment
simPod
left a comment
There was a problem hiding this comment.
Sure, added explanatory comments just fyi
|
|
||
| /** | ||
| * @psalm-pure | ||
| * @psalm-suppress InvalidCast |
| * Returns all possible values as an array | ||
| * | ||
| * @psalm-pure | ||
| * @psalm-suppress ImpureStaticProperty |
|
|
||
| /** @psalm-var T $value */ | ||
| foreach (static::toArray() as $key => $value) { | ||
| /** @psalm-suppress UnsafeGenericInstantiation */ |
Contributor
Author
There was a problem hiding this comment.
IMO true, generic params may indeed be constrained in children
| $message = "No static method or enum constant '$name' in class " . static::class; | ||
| throw new \BadMethodCallException($message); | ||
| } | ||
| /** @psalm-suppress UnsafeGenericInstantiation */ |
Contributor
Author
There was a problem hiding this comment.
IMO true, generic params may indeed be constrained in children
- Lock to v4.9 otherwise it bumps automatically, finds new issues and builds start failing without any change in this lib - fix some psalm issues - enable `findUnusedPsalmSuppress`
|
hi, any plans to merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findUnusedPsalmSuppress