feat(noq)!: open path by four tuple#653
Closed
Frando wants to merge 1 commit into
Closed
Conversation
Frando
force-pushed
the
Frando/open-path-by-four-tuple
branch
from
d062111 to
fce5351
Compare
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5394.8 Mbps | 8012.9 Mbps | -32.7% | 93.6% / 98.6% |
| medium-concurrent | 5631.1 Mbps | 7726.1 Mbps | -27.1% | 92.9% / 97.8% |
| medium-single | 3585.5 Mbps | 4941.0 Mbps | -27.4% | 93.2% / 101.0% |
| small-concurrent | 3761.2 Mbps | 5318.7 Mbps | -29.3% | 97.7% / 153.0% |
| small-single | 3536.2 Mbps | 4841.6 Mbps | -27.0% | 90.3% / 98.1% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3142.8 Mbps | 4045.9 Mbps | -22.3% |
| lan | 782.4 Mbps | 810.3 Mbps | -3.4% |
| lossy | 69.8 Mbps | 69.8 Mbps | ~0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 27.5% slower on average
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/653/docs/noq/ Last updated: 2026-05-13T18:22:38Z |
flub
reviewed
May 14, 2026
| /// | ||
| /// [`open_path`]: Self::open_path | ||
| pub fn open_path_ensure(&self, addr: SocketAddr, initial_status: PathStatus) -> OpenPath { | ||
| pub fn open_path_ensure(&self, addr: SocketAddr, opts: OpenPathOpts) -> OpenPath { |
Collaborator
There was a problem hiding this comment.
In my mind I was expecting to change addr: SocketAddr into network_path: FourTuple. That would mean making FourTuple public I guess but is kind of consistent with how things are named, at least with the internals.
Wonder what @matheus23 's thinks.
Collaborator
|
Not sure if you've looked at the iroh side yet, I've always wondered if the |
2 tasks
Member
Author
|
Replaced by #655 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an option to open paths with a specific local IP. To not give
Connection::open_patha third argument this adds aOpenPathOptswhich contains the initial path status and the optional local IP.Breaking Changes
noq::Connection::open_pathandopen_path_ensurenow take anopts: OpenPathOptsargument instead ofinitial_status. UseOpenPathOpts::default().initial_status(PathStatus::Backup)to set the initial status. The default isPathStatus::AvailableNotes & open questions
Change checklist