BCF-6454: Linux system state backup error "Unknown bootloader (GRUB2-BLS)"#79
Open
Andrus Suvalau (svlv) wants to merge 5 commits intodevelopfrom
Conversation
On RHEL-based systemsi, $BOOT is set /boot, which means that boot entries are located in /boot/loader/entries. These systems also call blscfg in /boot/grub2/grub.cfg to populate the voot menu, what can be use as an indicator that the system is using GRUB2 with BLS.
Andrus Suvalau (svlv)
changed the title
Andrus Suvalau (svlv)
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds support for the GRUB2-BLS (Boot Loader Specification) bootloader to address recovery failures on systems using this bootloader configuration. The implementation treats GRUB2-BLS similarly to GRUB2-EFI during the recovery process.
Changes:
- Added GRUB2-BLS detection logic based on the presence of
blscfgcommand in grub.cfg - Configured bootloader file checks for both RHEL-based systems (using /boot) and openSUSE Tumbleweed (using /boot/efi)
- Implemented initramfs rebuild support using
sdbootutilfor GRUB2-BLS systems
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| usr/share/rear/layout/save/default/445_guess_bootloader.sh | Adds detection logic for GRUB2-BLS by checking for blscfg command in grub.cfg |
| usr/share/rear/layout/save/default/450_check_bootloader_files.sh | Defines configuration files to check for GRUB2-BLS on both RHEL and openSUSE systems |
| usr/share/rear/finalize/default/050_prepare_checks.sh | Updates documentation to include GRUB2-BLS in the list of supported bootloaders |
| usr/share/rear/finalize/SUSE_LINUX/i386/550_rebuild_initramfs.sh | Implements initramfs regeneration for GRUB2-BLS using sdbootutil |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Make error messages shorter for Cove Jira-Ref: BCF-6454: Linux system state backup error "Unknown bootloader (GRUB2-BLS)"
…p-unknown-bootloader-grub2-bls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details:
Type: Enhancement
Impact: Normal
Reference to related issue (URL): https://n-able.atlassian.net/browse/BCF-6454
How was this pull request tested?
Manually recovered openSUSE Tumbleweed, RHEL 10, Fedora 43 and Rocky 9.6 cloud image in Azure
Description of the changes in this pull request:
Add support for
GRUB2-BLS. The recovery process is identical toGRUB2-EFI.