Skip to content

fix: set resourceRef before resolving query input parameters#207

Merged
jlouvel merged 2 commits intomainfrom
fix/query-params-lost-before-set-resource-ref
Apr 1, 2026
Merged

fix: set resourceRef before resolving query input parameters#207
jlouvel merged 2 commits intomainfrom
fix/query-params-lost-before-set-resource-ref

Conversation

@eskenazit
Copy link
Copy Markdown
Contributor

Related Issue

Closes #206


What does this PR do?

In OperationStepExecutor.findClientRequestFor(), resolveInputParametersToRequest() was called before setResourceRef(). For in: query parameters, the resolver appends the query string to the current resourceRef, which was still null at that point, producing null?status=active. The subsequent setResourceRef(clientResUri) then overwrote it, silently dropping the query string.

Fix: moved setResourceRef and setMethod before the two resolveInputParametersToRequest calls.

Also fixed HeaderQueryIntegrationTest: the existing assertion was a tautology (a || !b where b was always false), so the test always passed. Replaced with two explicit assertions and added a comment explaining the intent of the q=%22 guard.


Checklist

  • CI is green (build, tests, schema validation, security scans)
  • Rebased on latest main
  • Small and focused — one concern per PR
  • Commit messages follow Conventional Commits

Agent Context (optional)

agent_name: GitHub Copilot
lml: Claude Sonnet 4.6
tool: VS Code Copilot Chat
confidence: high

@eskenazit eskenazit requested a review from jlouvel April 1, 2026 14:02
Copy link
Copy Markdown
Contributor

@jlouvel jlouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlouvel jlouvel merged commit 5af5ffb into main Apr 1, 2026
2 checks passed
@jlouvel jlouvel deleted the fix/query-params-lost-before-set-resource-ref branch April 1, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Query parameters with in: query are lost due to incorrect order of setResourceRef and resolveInputParametersToRequest

2 participants