fix: set resourceRef before resolving query input parameters#207
Merged
fix: set resourceRef before resolving query input parameters#207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #206
What does this PR do?
In
OperationStepExecutor.findClientRequestFor(),resolveInputParametersToRequest()was called beforesetResourceRef(). Forin: queryparameters, the resolver appends the query string to the currentresourceRef, which was stillnullat that point, producingnull?status=active. The subsequentsetResourceRef(clientResUri)then overwrote it, silently dropping the query string.Fix: moved
setResourceRefandsetMethodbefore the tworesolveInputParametersToRequestcalls.Also fixed
HeaderQueryIntegrationTest: the existing assertion was a tautology (a || !bwherebwas always false), so the test always passed. Replaced with two explicit assertions and added a comment explaining the intent of theq=%22guard.Checklist
mainAgent Context (optional)
agent_name: GitHub Copilot
lml: Claude Sonnet 4.6
tool: VS Code Copilot Chat
confidence: high