Skip to content

CMR-11083: Switch a SQL transaction to read only #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jceaser merged 3 commits into from
Feb 18, 2026
Merged

CMR-11083: Switch a SQL transaction to read only #2381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2cbdf0
CMR-11083: set the search transaction to readonly and test
jceaser Feb 10, 2026
5e370a8
CMR-11083: adding better logs for testing
jceaser Feb 17, 2026
6d53f1c
Merge branch 'master' into cmr-11083-readonly-transaction
jceaser Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions metadata-db-app/src/cmr/metadata_db/data/oracle/search.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

(def concept-type->columns
"A map of concept type to the columns for that type in the database."
(merge
(merge
{:granule (into common-columns
[:provider_id :parent_collection_id :delete_time :granule_ur])
:collection (into common-columns
Expand Down Expand Up @@ -79,7 +79,7 @@
(defn- params->sql-params
"Converts the search params into params that can be converted into a sql condition clause."
[concept-type providers params]
(if (or (every? :small providers)
(if (or (every? :small providers)
(single-table-with-providers-concept-type? concept-type)
(cc/generic-concept? concept-type))
(dissoc params :concept-type :exclude-metadata)
Expand Down Expand Up @@ -247,10 +247,13 @@
(letfn [(find-batch
[start-index]
(j/with-db-transaction
[conn db]
[conn db :isolation :read-committed :read-only? true]
Comment thread
jceaser marked this conversation as resolved.
(let [conditions [`(>= :id ~start-index)
`(< :id ~(+ start-index batch-size))]
_ (info (format "Finding batch for provider [%s] concept type [%s] from id >= %s and id < %s"
_ (info (format (str "find-concepts-in-batches: "
"Finding batch for provider [%s] concept type [%s] "
"from id >= %s and id < %s using read-only transaction "
"with read committed isolation level.")
provider-id
(name concept-type)
start-index
Expand All @@ -262,6 +265,14 @@
(from table)
(where (cons `and conditions))))
batch-result (su/query db stmt)]
(info (format (str "find-concepts-in-batches: "
"Found %d results in batch for provider [%s] concept type "
"[%s] from id >= %s and id < %s.")
(count batch-result)
provider-id
(name concept-type)
start-index
(+ start-index batch-size)))
(mapv (partial oc/db-result->concept-map concept-type conn provider-id)
batch-result))))
(lazy-find
Expand Down