Added onHover and onTapCancel callbacks#50
Open
apalala-dev wants to merge 2 commits intonateshmbhat:masterfrom
Open
Added onHover and onTapCancel callbacks#50apalala-dev wants to merge 2 commits intonateshmbhat:masterfrom
apalala-dev wants to merge 2 commits intonateshmbhat:masterfrom
Conversation
Owner
|
@apalala-dev thank you for your contribution ! :) there's a conflict in one file, please push a fix. |
# Conflicts: # lib/src/touchy_canvas.dart
Author
|
I updated the description and merged the conflict :) |
Open
|
Is there possible to process a review for this pull request please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touchable didn't provide
onTapCancelandonHovercallbacks, so I added them.It can be used to interact better with the canvas on web & desktop.
An example for the
onHoverusage is to display aMouseRegionwith aSystemMouseCursors.clickwhen hovering clickable parts of a canvas.On the other end,
onTapCancelallows to disable more easily a pressed state when cancelling a tap on a Shape.Example:
And in
MyCustomPainter's paint method: