Open
Conversation
Remove excanvas-compressed.js to avoid loading both excanvas.js and excanvas-compressed.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excanvas-compressed.jsis a compressed version ofexcanvas.jsand both files are loaded byrequire_treeinvendor/assets/javascripts/html5jp_graphs.js.They are (re-)compressed by Rails (
rake assets:precompile) and therefore two sequences of almost duplicated code are generated.May I suggest removing
excanvas-compressed.js?I think that
excanvas.jswould be better because it has readability and maintainabilty and it will be finally compressed by Rails.