add encrytion_key and authentication_key functionallity for a protocol client#146
Draft
skrutzler wants to merge 1 commit intondokter:masterfrom
Draft
add encrytion_key and authentication_key functionallity for a protocol client#146skrutzler wants to merge 1 commit intondokter:masterfrom
skrutzler wants to merge 1 commit intondokter:masterfrom
Conversation
Collaborator
|
Hi, Thanks for your PR. You are still working on this as its still a draft. Let me know when it can be reviewed :) |
Author
|
Hello, yeah the PR is not ready yet. I was under the impression that the serial read was done for a full frame but apparently we read differently and that is not working out for decrypting telegrams which needs to have the full frame read (511bytes in my case) and then decrypt it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is only allowing the parser object to use a encryption and authentication key.
With this pull request it should now also be possible to use those keys when only the client is used by a application.
Following that changes I plan to add the functionality in the home-assistant dsmr plugin https://github.com/home-assistant/core/tree/dev/homeassistant/components/dsmr