Skip to content

refactor: extract statusline settings panel #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndycode wants to merge 3 commits into from
Closed

refactor: extract statusline settings panel #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f63e949
refactor: extract statusline settings panel
ndycode Mar 21, 2026
fd2b34b
Merge main into refactor/pr2-statusline-settings-split-2
ndycode Mar 22, 2026
c6de32c
test: cover statusline panel hotkeys
ndycode Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 12 additions & 195 deletions lib/codex-manager/settings-hub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
type DashboardDisplaySettingKey,
type DashboardDisplaySettingOption,
} from "./dashboard-display-panel.js";
import { promptStatuslineSettingsPanel } from "./statusline-settings-panel.js";
import { promptThemeSettingsPanel } from "./theme-settings-panel.js";

const DASHBOARD_DISPLAY_OPTIONS: DashboardDisplaySettingOption[] = [
Expand Down Expand Up @@ -139,14 +140,6 @@ type PreviewFocusKey =
| "menuLayoutMode"
| null;

type StatuslineConfigAction =
| { type: "toggle"; key: DashboardStatuslineField }
| { type: "move-up"; key: DashboardStatuslineField }
| { type: "move-down"; key: DashboardStatuslineField }
| { type: "reset" }
| { type: "save" }
| { type: "cancel" };

type BackendToggleSettingKey =
| "liveAccountSync"
| "sessionAffinity"
Expand Down Expand Up @@ -1356,193 +1349,17 @@ function reorderField(
async function promptStatuslineSettings(
initial: DashboardDisplaySettings,
): Promise<DashboardDisplaySettings | null> {
if (!input.isTTY || !output.isTTY) {
return null;
}

const ui = getUiRuntimeOptions();
let draft = cloneDashboardSettings(initial);
let focusKey: DashboardStatuslineField =
draft.menuStatuslineFields?.[0] ?? "last-used";
while (true) {
const preview = buildAccountListPreview(draft, ui, focusKey);
const selectedSet = new Set(
normalizeStatuslineFields(draft.menuStatuslineFields),
);
const ordered = normalizeStatuslineFields(draft.menuStatuslineFields);
const orderMap = new Map<DashboardStatuslineField, number>();
for (let index = 0; index < ordered.length; index += 1) {
const key = ordered[index];
if (key) orderMap.set(key, index + 1);
}

const optionItems: MenuItem<StatuslineConfigAction>[] =
STATUSLINE_FIELD_OPTIONS.map((option, index) => {
const enabled = selectedSet.has(option.key);
const rank = orderMap.get(option.key);
const label = `${formatDashboardSettingState(enabled)} ${index + 1}. ${option.label}${rank ? ` (order ${rank})` : ""}`;
return {
label,
hint: option.description,
value: { type: "toggle", key: option.key },
color: enabled ? "green" : "yellow",
};
});

const items: MenuItem<StatuslineConfigAction>[] = [
{
label: UI_COPY.settings.previewHeading,
value: { type: "cancel" },
kind: "heading",
},
{
label: preview.label,
hint: preview.hint,
value: { type: "cancel" },
color: "green",
disabled: true,
hideUnavailableSuffix: true,
},
{ label: "", value: { type: "cancel" }, separator: true },
{
label: UI_COPY.settings.displayHeading,
value: { type: "cancel" },
kind: "heading",
},
...optionItems,
{ label: "", value: { type: "cancel" }, separator: true },
{
label: UI_COPY.settings.moveUp,
value: { type: "move-up", key: focusKey },
color: "green",
},
{
label: UI_COPY.settings.moveDown,
value: { type: "move-down", key: focusKey },
color: "green",
},
{ label: "", value: { type: "cancel" }, separator: true },
{
label: UI_COPY.settings.resetDefault,
value: { type: "reset" },
color: "yellow",
},
{
label: UI_COPY.settings.saveAndBack,
value: { type: "save" },
color: "green",
},
{
label: UI_COPY.settings.backNoSave,
value: { type: "cancel" },
color: "red",
},
];

const initialCursor = items.findIndex(
(item) => item.value.type === "toggle" && item.value.key === focusKey,
);

const updateFocusedPreview = (cursor: number) => {
const focusedItem = items[cursor];
const focusedKey =
focusedItem?.value.type === "toggle" ? focusedItem.value.key : focusKey;
const nextPreview = buildAccountListPreview(draft, ui, focusedKey);
const previewItem = items[1];
if (!previewItem) return;
previewItem.label = nextPreview.label;
previewItem.hint = nextPreview.hint;
};

const result = await select<StatuslineConfigAction>(items, {
message: UI_COPY.settings.summaryTitle,
subtitle: UI_COPY.settings.summarySubtitle,
help: UI_COPY.settings.summaryHelp,
clearScreen: true,
theme: ui.theme,
selectedEmphasis: "minimal",
initialCursor: initialCursor >= 0 ? initialCursor : undefined,
onCursorChange: ({ cursor }) => {
const focusedItem = items[cursor];
if (focusedItem?.value.type === "toggle") {
focusKey = focusedItem.value.key;
}
updateFocusedPreview(cursor);
},
onInput: (raw) => {
const lower = raw.toLowerCase();
if (lower === "q") return { type: "cancel" };
if (lower === "s") return { type: "save" };
if (lower === "r") return { type: "reset" };
if (lower === "[") return { type: "move-up", key: focusKey };
if (lower === "]") return { type: "move-down", key: focusKey };
const parsed = Number.parseInt(raw, 10);
if (
Number.isFinite(parsed) &&
parsed >= 1 &&
parsed <= STATUSLINE_FIELD_OPTIONS.length
) {
const target = STATUSLINE_FIELD_OPTIONS[parsed - 1];
if (target) {
return { type: "toggle", key: target.key };
}
}
return undefined;
},
});

if (!result || result.type === "cancel") {
return null;
}
if (result.type === "save") {
return draft;
}
if (result.type === "reset") {
draft = applyDashboardDefaultsForKeys(draft, STATUSLINE_PANEL_KEYS);
focusKey = draft.menuStatuslineFields?.[0] ?? "last-used";
continue;
}
if (result.type === "move-up") {
draft = {
...draft,
menuStatuslineFields: reorderField(
normalizeStatuslineFields(draft.menuStatuslineFields),
result.key,
-1,
),
};
focusKey = result.key;
continue;
}
if (result.type === "move-down") {
draft = {
...draft,
menuStatuslineFields: reorderField(
normalizeStatuslineFields(draft.menuStatuslineFields),
result.key,
1,
),
};
focusKey = result.key;
continue;
}

focusKey = result.key;
const fields = normalizeStatuslineFields(draft.menuStatuslineFields);
const isEnabled = fields.includes(result.key);
if (isEnabled) {
const next = fields.filter((field) => field !== result.key);
draft = {
...draft,
menuStatuslineFields: next.length > 0 ? next : [result.key],
};
} else {
draft = {
...draft,
menuStatuslineFields: [...fields, result.key],
};
}
}
return promptStatuslineSettingsPanel(initial, {
cloneDashboardSettings,
buildAccountListPreview,
normalizeStatuslineFields,
formatDashboardSettingState,
reorderField,
applyDashboardDefaultsForKeys,
STATUSLINE_FIELD_OPTIONS,
STATUSLINE_PANEL_KEYS,
UI_COPY,
});
}

async function configureStatuslineSettings(
Expand Down
Loading