Added firstDuplicate, firstNotRepeatingCharacter and rotateImage#5
Open
abhikbob wants to merge 2 commits into
Open
Added firstDuplicate, firstNotRepeatingCharacter and rotateImage#5abhikbob wants to merge 2 commits into
abhikbob wants to merge 2 commits into
Conversation
neerajjain92
requested changes
Oct 7, 2019
Owner
neerajjain92
left a comment
neerajjain92
left a comment
There was a problem hiding this comment.
👎 ClassName Should not be in camel case. Also, It would be great if you can add a working example of the problem with at least 5 test case
Author
|
I made changes to the codes, making them into working programs. Also, I
used camel case in my first commit as thats how it is written on Code
Signal.
…On Mon, Oct 7, 2019 at 12:51 PM Neeraj Jain ***@***.***> wrote:
***@***.**** requested changes on this pull request.
👎 ClassName Should not be in camel case. Also, It would be great if you
can add a working example of the problem with at least 5 test case
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AJBHLTAYFFABDQVY6A565HDQNLPN7A5CNFSM4I6ARJZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHBCZ4Q#pullrequestreview-297938162>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJBHLTGQPY4U3Q5XIDE6KGLQNLPN7ANCNFSM4I6ARJZQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added firstDuplicate, firstNotRepeatingCharacter and rotateImage from Interview Practice in CodeSignal.