Support pre-1.17 MCPConfig versions#110
Open
embeddedt wants to merge 20 commits into
Open
Conversation
These need --mcp-mapping-data and --java-executable provided in order to work correctly
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of #51. This has been tested with a modified MDG and confirmed to work in vanilla mode. (In Forge mode, the JAR is produced and added to the project correctly, but does not actually run as MDG skips adding the FML dependency. This is not an NFRT defect.)
For pre-1.17 versions to work, an MCP-style mappings zip must be provided via
--mcp-mappings-data. This will be used in place of Mojmap to remap the SRG method/field names to friendly ones.