[POC] Use Apache Commons Compress for faster zip transfers#81
Draft
Technici4n wants to merge 3 commits into
Draft
[POC] Use Apache Commons Compress for faster zip transfers#81Technici4n wants to merge 3 commits into
Technici4n wants to merge 3 commits into
Conversation
|
|
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
neoforged-automation
Bot
added
the
needs rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the Java stdlib does not offer a way to copy entries from one zip to another without deflating and reinflating them. But with Apache Commons Compress, we can use
destinationStream.addRawArchiveEntry(entry, jar.getRawInputStream(entry));which avoids the decompression+recompression round-trip.This is a quick proof of concept, on the two
striptasks.Before:
After: