Add string extension methods #10
Conversation
|
/_8c779
/f8d494
/fcc13d
/ff5d4f
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8c476d9 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds string extension methods to the Neolution.Utilities library, specifically implementing Truncate methods for string manipulation. The implementation provides two overloads: one with a simple maximum length parameter and another that accepts a suffix to append when truncation occurs.
- Implements
Truncateextension methods for strings with optional suffix support - Adds comprehensive unit tests covering various scenarios including null/empty strings and edge cases
- Updates the changelog to document the new string extension methods
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Neolution.Utilities/StringExtensions.cs | Implements the Truncate extension methods with proper null handling and range slicing |
| Neolution.Utilities.UnitTests/StringExtensionsTests.cs | Comprehensive unit tests covering edge cases and various input scenarios |
| CHANGELOG.md | Documents the addition of string extension methods |
Comments suppressed due to low confidence (1)
Neolution.Utilities.UnitTests/StringExtensionsTests.cs:45
- This test case exposes a potential issue where maxLength is 0 but the result exceeds that length due to the suffix. Consider adding test cases for negative maxLength values and null suffix to ensure proper error handling.
[InlineData("abcdef", 0, "!", "!")]
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
2 participants
No description provided.