Add string utility functions: trimStart, trimEnd, trim #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds three new string utility functions for trimming specific substrings from strings: ltrim (left trim), rtrim (right trim), and trim (both sides). These functions extend the existing string utilities by allowing removal of custom needle strings rather than just whitespace.
- Added
ltrim,rtrim, andtrimfunctions to handle custom substring trimming - Comprehensive test coverage for all three functions including edge cases
- Updated CHANGELOG.md to document the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/string.ts | Implements the three new trim functions with proper null/undefined handling |
| src/lib/string.spec.ts | Adds comprehensive test cases covering normal usage and edge cases |
| CHANGELOG.md | Documents the addition of the new string utility functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dom-baur
changed the title
commit: |
dom-baur
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
drebrez
reviewed
Aug 26, 2025
manni497
requested changes
Sep 8, 2025
…im to trimEnd and improved the code
manni497
changed the title
manni497
requested changes
Sep 9, 2025
manni497
previously approved these changes
Sep 9, 2025
Collaborator
|
@drebrez THe PR is fine for me, I will let you double check and merge it if it's fine :) |
|
drebrez
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add features ltrim, rtrim and trim for issue #29