Add string utility functions: splitLines #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new string utility function splitLine that splits strings at line breaks, supporting different line ending formats (LF, CR, CRLF).
- Added
splitLinefunction to handle cross-platform line break splitting - Comprehensive test coverage for various line ending scenarios
- Updated changelog to document the new feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/string.ts | Implements the new splitLine function with regex pattern for line breaks |
| src/lib/string.spec.ts | Adds comprehensive test cases covering single line, multiple line endings, and edge cases |
| CHANGELOG.md | Documents the addition of the new string utility function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
drebrez
reviewed
Aug 26, 2025
drebrez
reviewed
Aug 26, 2025
drebrez
reviewed
Aug 27, 2025
drebrez
reviewed
Sep 4, 2025
drebrez
reviewed
Sep 4, 2025
drebrez
reviewed
Sep 8, 2025
dom-baur
changed the title
drebrez
reviewed
Sep 8, 2025
|
drebrez
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature splitLines for issue #29