Skip to content

Conversation

@manni497
Copy link
Collaborator

@manni497 manni497 commented Oct 7, 2025

No description provided.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/neolution-ch/react-data-table/@neolution-ch/react-data-table@82

commit: e4c130e

@manni497 manni497 requested a review from Copilot October 7, 2025 09:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds virtualization features to the ReactDataTable component, allowing for better performance when rendering large datasets by only rendering visible rows.

  • Adds virtualization support using @tanstack/react-virtual
  • Refactors table body rendering into a separate component for better organization
  • Removes sub-row functionality and paging navigation components

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/lib/ReactDataTable/VirtualizationOptions.ts Defines TypeScript types for virtualization configuration
src/lib/ReactDataTable/TableRows.tsx Removes sub-row component support from table row rendering
src/lib/ReactDataTable/TableBody.tsx New component to handle table body rendering with virtualization support
src/lib/ReactDataTable/ReactDataTableProps.ts Updates props interface to include virtualization options and removes deprecated properties
src/lib/ReactDataTable/ReactDataTable.tsx Major refactor to support virtualization with conditional rendering based on virtualization settings
package.json Adds @tanstack/react-virtual dependency
CHANGELOG.md Documents the addition of virtualization features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@manni497 manni497 marked this pull request as ready for review October 7, 2025 10:37
@manni497 manni497 merged commit 910420b into main Oct 8, 2025
6 checks passed
@manni497 manni497 deleted the feature/virtualization branch October 8, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants