-
Notifications
You must be signed in to change notification settings - Fork 13
Virtualization #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtualization #82
Conversation
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds virtualization features to the ReactDataTable component, allowing for better performance when rendering large datasets by only rendering visible rows.
- Adds virtualization support using
@tanstack/react-virtual - Refactors table body rendering into a separate component for better organization
- Removes sub-row functionality and paging navigation components
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/ReactDataTable/VirtualizationOptions.ts | Defines TypeScript types for virtualization configuration |
| src/lib/ReactDataTable/TableRows.tsx | Removes sub-row component support from table row rendering |
| src/lib/ReactDataTable/TableBody.tsx | New component to handle table body rendering with virtualization support |
| src/lib/ReactDataTable/ReactDataTableProps.ts | Updates props interface to include virtualization options and removes deprecated properties |
| src/lib/ReactDataTable/ReactDataTable.tsx | Major refactor to support virtualization with conditional rendering based on virtualization settings |
| package.json | Adds @tanstack/react-virtual dependency |
| CHANGELOG.md | Documents the addition of virtualization features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.