migrate to eslint 9 #83

neotob · 2025-10-09T08:47:30Z

No description provided.

neotob · 2025-10-09T08:48:54Z

CHANGELOG.md

+### Changed
+
+- migrated to eslint 9 flat config
+- removed obsolete storybook


I will readd the storybook in a next pr with an updated of all the used packages... the current storybook version was still using the old before tanstack table and was therefor not useful anymore at all.

pkg-pr-new · 2025-10-09T08:49:04Z

Open in StackBlitz

npm i https://pkg.pr.new/neolution-ch/react-data-table/@neolution-ch/react-data-table@83

commit: 631bac7

src/lib/utils/createReactDataTableColumnHelper.tsx

package.json

drebrez · 2025-10-09T11:58:39Z

src/lib/ReactDataTable/ReactDataTable.tsx

  virtualizer?: Virtualizer<HTMLDivElement, Element>;
 }

+// eslint-disable-next-line complexity


the complexity is really low in the eslint-config-neolution, is there a reason to have 12 in the package instead of the default 20?

it was initially taken over from the config we had in whitelabel:
https://github.com/neolution-ch/neolution-dotnet-templates/pull/230/files#diff-c853350721291cfdc71a00324eb7d2ab43b4db04f74afefc6ff5ac4b4f3a7f4f
but i will take it on the list to discuss and maybe increase directly in the package 💪

discussed and adjusted to the default values 💪

drebrez · 2025-10-09T12:58:10Z

src/lib/useReactDataTable/useReactDataTable.tsx


  // If we active the manual filtering, we have to unset the filter function, else it still does automatic filtering
-  if (manualFiltering) columns.forEach((x) => (x.filterFn = undefined));
+  if (manualFiltering) for (const x of columns) x.filterFn = undefined;


there's no rule to have these logics with curly braces blocks?
nesting so much with the "inline block" might be dangerous and less readable, no?

my suggestion is to have it like this always:

if (manualFiltering) { for (const x of columns) { x.filterFn = undefined; } }

are you aware of a rule like this? at least to limit to only allow 1 nested inline block?

seems there's no way to limit to only 1 nested, would be interesting in big projects to see what happens by enabling this:

https://eslint.org/docs/latest/rules/curly#all

mhmm that is actually interesting, honestly this part was autoupdated by eslint, so I didnt put too much thoughts into it... but we also have a rule like this in c#, maybe I can take that as another point to discuss.. you would be for enabling this rule, right?

I checked this with Timothy and added to my tech tasks, to check this rule in a big current project (for example hbl), to figure out, how well the configuration and especially the autofix works :) will keep you up to date as soon as I have a result there.

drebrez · 2025-10-09T13:06:55Z

package.json

-    "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-storybook": "^0.6.12",
+    "eslint": "^9.37.0",
+    "eslint-plugin-storybook": "^0.10.0",


I guess many libraries will need the eslint-plugin-storybook, is not worth to have it directly in eslint-config-neolution?
don't think those few kb are a problem for projects not actually using it

The storybooks were super neglejected in most projects, in this one here, it still had the reference to the datatable before we even used tanstack 😆 That's why initially it was not included in the package rule set.. but now with the possibility to configure the rules, it would definitely be an option and nicer... I will also take that on the list to discuss.. I think we should discuss in general, if out packages should include a story book or not (and then should also be maintained)

storybook will be added to the eslint package, task is on my list :)

manni497 · 2026-01-08T07:05:02Z

src/lib/ReactDataTable/ReactDataTable.tsx

 import { getFilterValue, setFilterValue } from "../utils/customFilterMethods";
 import { useVirtualizer, Virtualizer } from "@tanstack/react-virtual";
-import { useRef } from "react";
+


@neotob The empty line could be removed at all :)

@manni497 random newline removed :D

manni497 · 2026-01-08T07:06:10Z

src/lib/ReactDataTable/ReactDataTable.tsx

-export { ReactDataTable, ReactDataTableProps };
+export { ReactDataTable };
+
+export { ReactDataTableProps } from "./ReactDataTableProps";


It was a strange implementation before, make sense to add the ReactDataTableProps directly to the index.ts instead?

i was thinking the same, but I didn't dare to break anything just because of a eslint upgrade :D

manni497 · 2026-01-08T07:07:37Z

src/lib/useReactDataTable/useReactDataTable.tsx

+
+export { useReactDataTableProps } from "./useReactDataTableProps";
+
+export { useReactDataTableResult } from "./useReactDataTableResult";


Same here, makes sense to add both files to the index.ts?

manni497 · 2026-01-08T07:08:16Z

src/lib/useReactDataTableState/useReactDataTableState.ts

-export { useReactDataTableState, useReactDataTableStateProps, useReactDataTableStateResult };
+export { useReactDataTableState };
+
+export { useReactDataTableStateProps } from "./useReactDataTableStateProps";


Same as previous comment :)

manni497 · 2026-01-08T07:09:59Z

src/react-table.d.ts

@@ -1,4 +1,5 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
+/* eslint-disable import/no-duplicates */
 import "@tanstack/react-table";


@neotob Have you tried to remove this import?

same here, not sure what this did, but at least the pipelines are still happy :P

manni497 · 2026-01-08T07:11:00Z

rollup.config.mjs

@@ -1,4 +1,5 @@
 import commonjs from "@rollup/plugin-commonjs";
+// eslint-disable-next-line import/no-named-as-default
 import nodeResolve from "@rollup/plugin-node-resolve";


I think we found a solution for this?

You should use a different name or import default as :)

used another name thanks :)

migrate to eslint 9

b75dd9d

neotob commented Oct 9, 2025

View reviewed changes

src/lib/utils/createReactDataTableColumnHelper.tsx Outdated Show resolved Hide resolved

update

075b7e0

neotob commented Oct 9, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

fix

5f281ee

drebrez reviewed Oct 9, 2025

View reviewed changes

neotob added 5 commits December 21, 2025 21:23

fix

36a82cb

update

6be3281

Merge branch 'main' into feature/eslint-9

e66ee13

fix

be12dd8

fix

03a3f41

neotob requested a review from manni497 January 7, 2026 08:44

manni497 requested changes Jan 8, 2026

View reviewed changes

update review

631bac7

neotob requested a review from manni497 January 9, 2026 07:40


		export { useReactDataTableProps } from "./useReactDataTableProps";

		export { useReactDataTableResult } from "./useReactDataTableResult";

migrate to eslint 9 #83

Are you sure you want to change the base?

migrate to eslint 9 #83

Uh oh!

Conversation

neotob commented Oct 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drebrez Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pkg-pr-new bot commented Oct 9, 2025 •

edited

Loading

drebrez Oct 9, 2025 •

edited

Loading