Conversation
MihaiBojin
left a comment
MihaiBojin
left a comment
There was a problem hiding this comment.
Left a few comments, nothing major. Would be great to include a short summary that explains what this code is aiming to do, maybe a few links to GH projects /screenshots showing before and after.
Thank you for writing it / we generally need more such code !!
| }).filter(pr => Boolean(pr)) as Array<Pick<NeonProject, 'projectId' | 'projectNumber' | 'updatedAtFieldId' | 'createdAtFieldId' | 'closedAtFieldId'>>; | ||
| console.log(config) | ||
|
|
||
| export const backfill_created_updated_deleted = async (octokit: ProbotOctokit) => { |
There was a problem hiding this comment.
splitting this out in multiple functions would make it easier to understand the intent behind the code :)
| while (pageInfo.hasNextPage) { | ||
| try { | ||
| const res: { | ||
| search: { |
There was a problem hiding this comment.
nit: I would move this to a separate file (if possible), as it would make it easier to lint and edit/maintain long term
| logger('error', e) | ||
| } | ||
| } | ||
| logger('info', `Set created at for issue #${issue.number} ${issue.title} in project ${project.projectId} with value ${createdAtFieldDesiredValue}`) |
There was a problem hiding this comment.
nit: might be confusing in dry-run mode / consider two log lines:
- attempting to do X (this line)
- did X / did not do X in dry-run
There was a problem hiding this comment.
yeah, I agree. It's how i did that in other places, so I'll keep it this way for now
| } catch(e) { | ||
| logger('error', e) | ||
| } | ||
| } |
2 participants
No description provided.