[codex] Apply Cedar authorization consistently to TData#278
Open
arun-pathiban-ddog wants to merge 3 commits into
Open
[codex] Apply Cedar authorization consistently to TData#278arun-pathiban-ddog wants to merge 3 commits into
arun-pathiban-ddog wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$count, and$selectauthorization-correctRoot Cause
Cedar authorization was applied to bound-action POST handling, but normal read routes and several mutation/stream fast paths could return or change entity data without going through the same policy evaluation boundary. Optimized list pagination and projection also could not be safely reused once per-row Cedar checks became mandatory.
Impact
Entity reads now require
read, collections requirelistand filter rows throughread, and collection expansions requirelistbefore child reads. Normal creates, updates, deletes, stream uploads/downloads, and raw content-addressed ingestion now enforce the matching Cedar action. Denied writes continue to record authorization decisions.Discovery endpoints such as the service document,
$metadata, and$hintsremain discovery surfaces;/tdata/$eventsalready uses itsread_eventsauthorization gate.Validation
cargo check -p temper-server --features simcargo test -p temper-server --features sim --test odata_read --test file_value_fast_pathcargo test -p temper-server --features sim --libgit diff --check