Add notice documenting LGPL modifications to wave_writer files#2
Open
TetherIO wants to merge 4 commits intonesbox:masterfrom
Open
Add notice documenting LGPL modifications to wave_writer files#2TetherIO wants to merge 4 commits intonesbox:masterfrom
TetherIO wants to merge 4 commits intonesbox:masterfrom
Conversation
TetherIO
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a notice documenting previously made modifications to the wave_writer files.
The affected code originates from blip_buf by Shay Green, which is licensed under the GNU Lesser General Public License v2.1 or later. A notice has been added to clarify the origin of the code and describe later modifications made in this repository.
Specifically, on 25 Nov 2020, Vadim Grigoruk modified the wave_writer files to improve Windows compatibility by adding wide-character file opening support for MSVC and MinGW builds. The change introduces a wrapper around file opening that allows UTF-8 filenames to be opened through Windows wide-character APIs.