Import '@fastify/view' for Fastify reply type augmentation#3341
Open
gianlazz wants to merge 1 commit intonestjs:masterfrom
Open
Import '@fastify/view' for Fastify reply type augmentation#3341gianlazz wants to merge 1 commit intonestjs:masterfrom
gianlazz wants to merge 1 commit intonestjs:masterfrom
Conversation
Added import statement for '@fastify/view' to enhance Fastify reply type with view property to avoid the type error below: Property 'view' does not exist on type 'FastifyReply<RouteGenericInterface, RawServerDefault, IncomingMessage, ServerResponse<IncomingMessage>, unknown, FastifySchema, FastifyTypeProviderDefault, unknown>'.ts(2339)
Author
|
Hmm, actually, I'm still getting response.view is not a defined... maybe this isn't a documentation issue. I'm encountering this in my exception filter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added import statement for '@fastify/view' to enhance Fastify reply type with view property to avoid the type error below:
Property 'view' does not exist on type 'FastifyReply<RouteGenericInterface, RawServerDefault, IncomingMessage, ServerResponse, unknown, FastifySchema, FastifyTypeProviderDefault, unknown>'.ts(2339)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Calling reply.view() results in the folling error if
import '@fastify/view';is not called inmain.tsProperty 'view' does not exist on type 'FastifyReply<RouteGenericInterface, RawServerDefault, IncomingMessage, ServerResponse<IncomingMessage>, unknown, FastifySchema, FastifyTypeProviderDefault, unknown>'.ts(2339)Issue Number: N/A
What is the new behavior?
viewproperty is found on reply object.Does this PR introduce a breaking change?
Other information