Skip to content

Ensure valid type is passed into insert()#314

Closed
mskocik wants to merge 11 commits into
nette:masterfrom
mskocik:patch-1
Closed

Ensure valid type is passed into insert()#314
mskocik wants to merge 11 commits into
nette:masterfrom
mskocik:patch-1

Conversation

@mskocik
Copy link
Copy Markdown

@mskocik mskocik commented Jun 13, 2024

Making sure that HTMLStringable or string is passed into Html::insert() method

@dg dg force-pushed the master branch 14 times, most recently from 6733224 to 5de10a1 Compare June 18, 2024 21:22
@dg dg force-pushed the master branch 5 times, most recently from 1ce0dab to a3120d7 Compare August 7, 2024 10:08
@dg dg force-pushed the master branch 8 times, most recently from a702672 to 5ab770f Compare June 19, 2025 19:00
@dg dg force-pushed the master branch 3 times, most recently from 99fbd2d to 8ee89b1 Compare August 6, 2025 21:44
@dg dg force-pushed the master branch 6 times, most recently from 1765d9d to 17932ce Compare October 31, 2025 00:46
@dg dg force-pushed the master branch 7 times, most recently from ad7c562 to baa7cb7 Compare December 1, 2025 17:42
@dg dg force-pushed the master branch 2 times, most recently from 5139bb3 to a8ed180 Compare December 29, 2025 00:34
@dg dg force-pushed the master branch 2 times, most recently from 4018aba to c5b54d1 Compare December 30, 2025 01:11
@dg
Copy link
Copy Markdown
Member

dg commented May 11, 2026

Superseded: master resolved #313 the opposite way — addHtml() now has the strict signature HtmlStringable|string instead of casting to string internally. This PR is also based on an old branch and mixes in many unrelated changes (Cast, MemoizingIterator, Iterables::memoize/toIterator, Image refactor, readme, CI bumps). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect argument type definition in addHtml method

2 participants