-
-
Notifications
You must be signed in to change notification settings - Fork 0
Bump @rollup components to latest versions and fix TypeScript compatibility #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nev21 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
|
@copilot investigate and fix the failures |
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Investigated and addressed the build failures. Key findings:
Fixed in commit a03fa18:
The eslint-ts-plugin errors appear to be longstanding issues - recent CI runs going back months show the same failures. These ESLint type errors are a separate issue from the @rollup dependency updates. |
|
@copilot recreate this PR |
PR has been recreated with all necessary changes: What's included:
Build verification:
All commits (4d3e9b1, 412988f, df7a3c6, a03fa18) are already on the branch. The PR is ready for review. |
|
@copilot rebase and resolve conflicts |
Successfully rebased onto latest main branch and resolved all conflicts. What was done:
Changes in commit ec3b540:
Build verification: The local branch is ready. Note: A force push to origin/copilot/fix-316 is required to update the remote branch with the rebased history. |
^25.0.7to^28.0.6^15.2.3to^16.0.1^18.11.18to^20.17.10for TypeScript 5.2 compatibilitySummary
Successfully bumped @rollup plugins to their latest versions and updated @types/node for better compatibility with TypeScript 5.2.2.
Changes Made
Package Updates:
^25.0.7→^28.0.6^15.2.3→^16.0.1^18.11.18→^20.17.10Files Updated:
/package.json(root)/shared/package.json/ts-plugin/package.json/eslint-ts-plugin/package.jsoncommon/config/rush/npm-shrinkwrap.json(lockfile)Rebase Resolution
Successfully rebased the PR onto the latest main branch which includes:
Build Status
✅ shared package - Builds and packages successfully with new @rollup versions
✅ ts-plugin package - Builds and packages successfully with new @rollup versions
✅ eslint-ts-plugin package - Now builds successfully (fixed by main branch updates)
✅ Rollup configurations - Compatible with new plugin versions
All three packages now build successfully. The existing rollup configurations use standard plugin APIs maintained for backwards compatibility, ensuring a smooth upgrade path.
Fixes #316
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.