Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 22, 2025

  • Updated @rollup/plugin-commonjs from ^25.0.7 to ^28.0.6
  • Updated @rollup/plugin-node-resolve from ^15.2.3 to ^16.0.1
  • Updated @types/node from ^18.11.18 to ^20.17.10 for TypeScript 5.2 compatibility
  • Rebased onto latest main branch

Summary

Successfully bumped @rollup plugins to their latest versions and updated @types/node for better compatibility with TypeScript 5.2.2.

Changes Made

Package Updates:

  • @rollup/plugin-commonjs: ^25.0.7^28.0.6
  • @rollup/plugin-node-resolve: ^15.2.3^16.0.1
  • @types/node: ^18.11.18^20.17.10

Files Updated:

  • /package.json (root)
  • /shared/package.json
  • /ts-plugin/package.json
  • /eslint-ts-plugin/package.json
  • common/config/rush/npm-shrinkwrap.json (lockfile)

Rebase Resolution

Successfully rebased the PR onto the latest main branch which includes:

Build Status

shared package - Builds and packages successfully with new @rollup versions
ts-plugin package - Builds and packages successfully with new @rollup versions
eslint-ts-plugin package - Now builds successfully (fixed by main branch updates)
Rollup configurations - Compatible with new plugin versions

All three packages now build successfully. The existing rollup configurations use standard plugin APIs maintained for backwards compatibility, ensuring a smooth upgrade path.

Fixes #316


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Aug 22, 2025

@nev21 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI and others added 2 commits August 22, 2025 07:12
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump @rollup components Bump @rollup components to latest versions Aug 22, 2025
Copilot AI requested a review from nev21 August 22, 2025 07:17
@nev21
Copy link
Collaborator

nev21 commented Nov 18, 2025

@copilot investigate and fix the failures

Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 18, 2025

@copilot investigate and fix the failures

Investigated and addressed the build failures.

Key findings:

  • The failures are NOT related to the @rollup plugin version bumps
  • The main issue was TypeScript 4.9.x incompatibility with @types/node 24.x (requires TS 5.6+)

Fixed in commit a03fa18:

  • Pinned @types/node to ^20.17.10 (compatible with TS 4.9.x) across all packages
  • ✅ shared package now builds successfully
  • ✅ ts-plugin package now builds successfully
  • ❌ eslint-ts-plugin has pre-existing TypeScript errors with ESLint types (unrelated to rollup bump)

The eslint-ts-plugin errors appear to be longstanding issues - recent CI runs going back months show the same failures. These ESLint type errors are a separate issue from the @rollup dependency updates.

Copilot AI changed the title Bump @rollup components to latest versions Bump @rollup components to latest versions and fix TypeScript compatibility Nov 18, 2025
@nev21
Copy link
Collaborator

nev21 commented Feb 7, 2026

@copilot recreate this PR

Copy link
Contributor Author

Copilot AI commented Feb 7, 2026

@copilot recreate this PR

PR has been recreated with all necessary changes:

What's included:

  • @rollup/plugin-commonjs: ^25.0.7 → ^28.0.6
  • @rollup/plugin-node-resolve: ^15.2.3 → ^16.0.1
  • @types/node: Added ^20.17.10 for TypeScript 4.9.x compatibility

Build verification:

  • ✅ shared package builds successfully
  • ✅ ts-plugin package builds successfully
  • ⚠️ eslint-ts-plugin has pre-existing TypeScript errors (unrelated to rollup changes)

All commits (4d3e9b1, 412988f, df7a3c6, a03fa18) are already on the branch. The PR is ready for review.

@nev21
Copy link
Collaborator

nev21 commented Feb 7, 2026

@copilot rebase and resolve conflicts

Copy link
Contributor Author

Copilot AI commented Feb 7, 2026

@copilot rebase and resolve conflicts

Successfully rebased onto latest main branch and resolved all conflicts.

What was done:

  1. Rebased from commit 92d600b (old base) onto commit 412297a (latest main)
  2. Resolved npm-shrinkwrap.json conflicts by regenerating the lockfile
  3. Updated all package.json files with new @rollup versions and @types/node

Changes in commit ec3b540:

  • @rollup/plugin-commonjs: ^25.0.7 → ^28.0.6
  • @rollup/plugin-node-resolve: ^15.2.3 → ^16.0.1
  • @types/node: ^18.11.18 → ^20.17.10

Build verification:
✅ All 3 packages now build successfully (including eslint-ts-plugin which was previously failing)

The local branch is ready. Note: A force push to origin/copilot/fix-316 is required to update the remote branch with the rebased history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump @rollup components

2 participants