feat(core): add optimized createNotAdapter for negation operations #250
+801
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an optimized createNotAdapter function to avoid expression parsing overhead when wrapping scope functions with negation operations. The change replaces 47 instances of createExprAdapter("not", fn) with the more efficient createNotAdapter(fn).
Changes:
- Adds a new optimized adapter
createNotAdapterthat directly applies negation vianotOpinstead of parsing the "not" expression - Refactors all 47 "not" negation operations in
assertClass.tsto use the new adapter - Exports the new adapter from the package index for public use
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core/src/assert/adapters/notAdapter.ts | New file implementing the optimized negation adapter that directly calls notOp |
| core/src/assert/assertClass.ts | Replaced all 47 instances of createExprAdapter("not", fn) with createNotAdapter(fn) |
| core/src/index.ts | Added import and export for the new createNotAdapter function |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nev21
force-pushed
the
nev21/notAdapter
branch
2 times, most recently
from
2c2cf69 to
7748f14
Compare
Add a new `createNotAdapter` function that wraps scope functions with a
"not" operation more efficiently than `createExprAdapter("not", scopeFn)`.
This avoids expression parsing overhead by directly applying the negation
context via `notOp`.
Changes:
- Add core/src/assert/adapters/notAdapter.ts
- Replace all 47 usages of `createExprAdapter("not", fn)` with `createNotAdapter(fn)` in assertClass.ts
- Export `createNotAdapter` from the package index
nev21
force-pushed
the
nev21/notAdapter
branch
from
7748f14 to
5fca4ae
Compare
| // To verify negation is active, we check that an eval(true) fails | ||
| // and an eval(false) passes, which is the opposite of normal behavior | ||
| let evalTrueResult: boolean | undefined; | ||
| let evalFalseResult: boolean | undefined; |
There was a problem hiding this comment.
Unused variable evalFalseResult.
Contributor
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
createNotAdapterfunction that wraps scope functions with a "not" operation more efficiently thancreateExprAdapter("not", scopeFn). This avoids expression parsing overhead by directly applying the negation context vianotOp.Changes:
createExprAdapter("not", fn)withcreateNotAdapter(fn)in assertClass.tscreateNotAdapterfrom the package index