Fix UpdateGithubDataJob email validation failures#138
Merged
Conversation
UpdateGithubDataJob was failing for ~50% of users because GitHub's GraphQL API returns nil for private emails, triggering the email presence validation. Relaxed to allow_blank since this is OAuth-only. Removed NotifyAdminJob, AdminMailer, and associated views as they were unused beyond logging (which the job already does). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Multiple GitHub users have nil/blank emails (private email setting). The database-level UNIQUE index caused SQLite3::ConstraintException for these users during batch updates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow_blank— GitHub's GraphQL API returnsnilfor users with private emails, causing ~50% of batch updates to failNotifyAdminJob,AdminMailer, and associated views — failures are already logged by the job itselfTest plan
UpdateGithubDataJobrun completes without email validation errors🤖 Generated with Claude Code