Skip to content

Add FileSanitizer, RemotePathUtils, and comprehensive tests#16527

Open
amussara wants to merge 1 commit intonextcloud:masterfrom
amussara:improve/file-sanitizer-and-test-coverage
Open

Add FileSanitizer, RemotePathUtils, and comprehensive tests#16527
amussara wants to merge 1 commit intonextcloud:masterfrom
amussara:improve/file-sanitizer-and-test-coverage

Conversation

@amussara
Copy link

2 new Kotlin utility classes + 88 tests across 4 test files. 1,016 lines.

…unit tests

- Add FileSanitizer utility for cross-platform filename sanitization:
  - Unsafe character replacement (control chars, Windows-reserved chars)
  - Path traversal detection and bidi character detection/removal
  - Windows reserved name detection, filename truncation preserving extensions
  - Unique filename generation with numeric suffixes

- Add RemotePathUtils utility for remote path manipulation:
  - Extract filename, parent path, extension from remote paths
  - Path depth calculation, joining, normalization
  - Ancestor path enumeration and folder path detection

- Add unit tests for FileSanitizer (30 test cases)
- Add unit tests for RemotePathUtils (28 test cases)
- Add unit tests for StringExtensions (18 test cases)
- Add unit tests for LogEntry parsing edge cases (12 test cases)

Signed-off-by: amussara <amussara@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant