Conversation
CarlSchwan
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
CarlSchwan
requested review from
hweihwang,
max-nextcloud and
mejo-
and removed request for
max-nextcloud,
mejo- and
silverkszlo
Member
|
Thanks @CarlSchwan, much appreciated 🙏 If it's not urgent on your side, I'd prefer to first fix the failing CI situation in Collectives and then get this merged. Code changes look good to me though. |
CarlSchwan
force-pushed
the
carl/cleanup
branch
from
05dbe5b to
7e80234
Compare
Member
Author
Not urgent, just slowly trying to remove some deprecated code in server and wanted to port first the apps to the new APIs before hand :) |
And some other minor cleanup Signed-off-by: Carl Schwan <carlschwan@kde.org>
No need to use the private API here Signed-off-by: Carl Schwan <carlschwan@kde.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
And some other minor cleanup
npm run lint/npm run stylelint/composer run cs:check)