Skip to content

feat: add context chat provider #11150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 35 commits into from
Jan 26, 2026
Merged

feat: add context chat provider #11150

ChristophWurst merged 35 commits into from
Jan 26, 2026

Conversation

@edward-ly
Copy link
Contributor

@edward-ly edward-ly commented May 15, 2025

No description provided.

@welcome
Copy link

welcome bot commented May 15, 2025

Thanks for opening your first pull request in this repository! ✌️

@edward-ly edward-ly mentioned this pull request May 15, 2025
Closed
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 3, 2025

It was decided that we should move on with this without nextcloud/server#52852.

I'll look for a way to make Psalm understand the foreign code.

@edward-ly edward-ly force-pushed the feat/context-chat branch 2 times, most recently from 16633b0 to a359dd7 Compare June 18, 2025 23:46
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 26, 2025

It was decided that we should move on with this without nextcloud/server#52852.

I'll look for a way to make Psalm understand the foreign code.

Since we have to do workarounds to get Psalm working with stubs, have a stub update mechanism, and additionally need the actual classes to be able to write tests, we decided that nextcloud/server#52852 should be pursued again. It's also an investment of time, but we'll have our standard setup for app communication through the OCP public API. That setup works for Psalm and PHPUnit.

@edward-ly edward-ly force-pushed the feat/context-chat branch 2 times, most recently from c2efb0b to 6a236d3 Compare July 9, 2025 22:04
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
@edward-ly edward-ly force-pushed the feat/context-chat branch 3 times, most recently from dd566f9 to a7bc7ba Compare July 15, 2025 23:43
marcelklehr
marcelklehr reviewed Jul 17, 2025
View reviewed changes
@edward-ly edward-ly force-pushed the feat/context-chat branch 8 times, most recently from 52dcdfc to 9077fa6 Compare July 24, 2025 06:41
marcelklehr
marcelklehr reviewed Jul 24, 2025
View reviewed changes
marcelklehr
marcelklehr approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me! If we can finish the tests, I'd look forward to a review from the groupware team 💙

marcelklehr
marcelklehr reviewed Jul 24, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 24, 2025
View reviewed changes
@marcelklehr
fix: Fix integration test
b7fd55e 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix: Fix integration test
94afb80 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr marked this pull request as ready for review December 4, 2025 14:21
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 18, 2025

Unfortunately harp responds with HTTP400 now so I can't retest. Contacted @kyteinsky privately to get this resolved.

  • UX bug: even if the integration is turned off by admins I see Mail - mail in the context chat dialogue as user. This might cause confusion when someone tries to use it when it's actually off.

@ChristophWurst ChristophWurst moved this from 🏗️ In progress to 📄 To do in 💌 📅 👥 Groupware team Jan 14, 2026
@ChristophWurst ChristophWurst moved this from 📄 To do to 🏗️ In progress in 💌 📅 👥 Groupware team Jan 14, 2026
@janepie janepie mentioned this pull request Jan 20, 2026
Open
ChristophWurst
ChristophWurst approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. Took me a bit to get back to a working context chat setup.

I was finally able to test this. It works :)

image

:shipit:

marcelklehr
marcelklehr reviewed Jan 21, 2026
View reviewed changes
marcelklehr
marcelklehr reviewed Jan 21, 2026
View reviewed changes
@marcelklehr
fix: Also test against server:stable31
886b1a8 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@DaphneMuller
Copy link

DaphneMuller commented Jan 21, 2026

@ChristophWurst I think we're done with your to do list from 18 November (#11150 (comment))

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 21, 2026

Yep :) This is ready for merge. There are just a few conflicts to resolve

@marcelklehr
Merge branch 'main' into feat/context-chat
c7a1d65 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Copy link
Member

marcelklehr commented Jan 22, 2026

Conflicts resolved.

@marcelklehr
Copy link
Member

marcelklehr commented Jan 22, 2026 •
edited
Loading

Actually, this PR does not fully work with stable31 (see psalm issues), should we adjust it to work with stable31?

@marcelklehr
fix: Run cs:fix
8483184 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 22, 2026 •
edited
Loading

31 goes EOL 2026-02 … I'll drop it from main

edit: #12295

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 22, 2026

You can update the branch to catch the updated CI and support range

@marcelklehr
Merge branch 'main' into feat/context-chat
e9d0695 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix: Fix unit tests
737f73e 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Copy link
Member

marcelklehr commented Jan 26, 2026

All fixed

ChristophWurst
ChristophWurst approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ChristophWurst ChristophWurst merged commit 0b4c310 into main Jan 26, 2026
41 of 42 checks passed
@ChristophWurst ChristophWurst deleted the feat/context-chat branch January 26, 2026 10:34
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jan 26, 2026
@marcelklehr
Copy link
Member

marcelklehr commented Jan 26, 2026

Woop woop

@kesselb kesselb mentioned this pull request Jan 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@kyteinsky kyteinsky kyteinsky left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

Assignees

@ChristophWurst ChristophWurst

@edward-ly edward-ly

Labels

2. developing enhancement

Projects

💌 📅 👥 Groupware team
Status: ☑️ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@edward-ly @ChristophWurst @marcelklehr @kesselb @kyteinsky @DaphneMuller