Skip to content

refactor: use strict comparison operator #57882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Altahrim merged 1 commit into from
Jan 29, 2026
Merged

refactor: use strict comparison operator #57882

Altahrim merged 1 commit into from
Jan 29, 2026

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jan 28, 2026 •
edited
Loading

Summary

Found no good reason for any of these to not be strict.
Not sure if this is a refactor or a fix 😆

Checklist

@solracsf solracsf added this to the Nextcloud 34 milestone Jan 28, 2026
@solracsf solracsf added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Jan 28, 2026
@solracsf solracsf force-pushed the useStrictComparisonOperator branch 2 times, most recently from dff849b to 427bbff Compare January 28, 2026 16:12
CarlSchwan
CarlSchwan approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

CarlSchwan
CarlSchwan reviewed Jan 28, 2026
View reviewed changes
@solracsf solracsf force-pushed the useStrictComparisonOperator branch 3 times, most recently from 1122f2a to d50b8b8 Compare January 28, 2026 18:22
@solracsf solracsf added the 2. developing Work in progress label Jan 28, 2026
@solracsf
refactor: use strict comparison operator
0803350 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the useStrictComparisonOperator branch from 818ed94 to 0803350 Compare January 28, 2026 20:12
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 28, 2026
@solracsf solracsf marked this pull request as ready for review January 28, 2026 20:24
@solracsf solracsf requested a review from a team as a code owner January 28, 2026 20:24
@solracsf solracsf requested review from Altahrim, icewind1991, leftybournes and sorbaugh and removed request for a team January 28, 2026 20:24
@Altahrim Altahrim merged commit 7f71b46 into master Jan 29, 2026
208 of 210 checks passed
@Altahrim Altahrim deleted the useStrictComparisonOperator branch January 29, 2026 08:20
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@Altahrim Altahrim Altahrim approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

4 participants

@solracsf @Altahrim @CarlSchwan