fix(perf): extract MessageTranslateDialog to spawnDialog#16973
Merged
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/message-actions-refactor
branch
from
85bbb24 to
e34577c
Compare
DorraJaouad
approved these changes
Feb 4, 2026
Contributor
DorraJaouad
left a comment
DorraJaouad
left a comment
There was a problem hiding this comment.
GTG
MessageForwarder,
Yeah, it cannot be transformed to a spawn imo.
Contributor
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
P.S. I tried to extract MessageForwarder, but it uses store and two dialogs inside of it, so it's not as simple as this 🦭
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No visual changes
🏁 Checklist