Skip to content

Pin reactions to the bottom of the message bubble #5674

Merged
mahibi merged 1 commit intomasterfrom
style/noid/reactionRevamp
Jan 8, 2026
Merged

Pin reactions to the bottom of the message bubble #5674
mahibi merged 1 commit intomasterfrom
style/noid/reactionRevamp

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Dec 30, 2025 •
edited
Loading

  • Pin reactions to the bottom of the message bubble and make them Material Cards
  • Pin ThreadButton to the bottom of the message bubble as well and adapt the border radius
  • Fix Thread Title alignment for outgoing messages with an image
  • Slight change in colors for the reactions background and adding a border to it
  • Please ignore any other aspects on the screenshots, some friction is due to the on-device scrolling screenshot feature I used to take the screenshots of a whole chat...
  • The PR add some extra lint warnings I couldn't work around (extra parent UI elements...) - if I remove them and work on the layouting the flex layout keeps breaking for reply-quotes in messages. Hence I left it as is for the moment

🖼️ Screenshots

🏚️ Before 🌞 🏚️ Before 🌑 🏡 After 🌞 🏡 After 🌑
Screenshot_2025-12-30-16-48-31-93 Screenshot_2025-12-30-16-47-21-92 Screenshot_2025-12-30-17-34-38-05 Screenshot_2025-12-30-17-33-29-27

🚧 TODO

  • get clarification/review on the design
  • code review

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added design Related to the design 2. developing Work in progress labels Dec 30, 2025
@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch 4 times, most recently from 72bac46 to 6630cba Compare December 30, 2025 15:34
@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Dec 30, 2025
@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch from 6630cba to 1708e75 Compare December 30, 2025 16:04
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 30, 2025
@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch 2 times, most recently from 9d188dc to e42053e Compare December 30, 2025 18:13
@AndyScherzinger AndyScherzinger added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 30, 2025
@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch from e42053e to 76a990b Compare December 30, 2025 18:16
@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch from 76a990b to d5a7a79 Compare January 1, 2026 12:40
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 1, 2026
@AndyScherzinger AndyScherzinger marked this pull request as ready for review January 1, 2026 13:50
@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch from d5a7a79 to f361568 Compare January 6, 2026 21:58
@sowjanyakch
Copy link
Copy Markdown
Contributor

sowjanyakch commented Jan 7, 2026

LGTM. One minor thing I noticed - the small captions are now right aligned.

small text captions

@AndyScherzinger
Copy link
Copy Markdown
Member Author

AndyScherzinger commented Jan 7, 2026

LGTM. One minor thing I noticed - the small captions are now right aligned.

Nice catch @sowjanyakch - also wrong in my screenshots, but totally missed that... 👍

@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch from f361568 to d4aae06 Compare January 7, 2026 16:48
@AndyScherzinger
Copy link
Copy Markdown
Member Author

AndyScherzinger commented Jan 7, 2026

@sowjanyakch issue with the caption seems to have only been the case for outcoming messages ans is fixed with the latest push. Feel free to re-review

@AndyScherzinger
style(reactions): Pin reactions to the bottom of the message bubble a…
10f206a 
…nd make them Material Cards

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the style/noid/reactionRevamp branch from d4aae06 to 10f206a Compare January 7, 2026 16:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5674.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2026

Codacy

Lint

TypemasterPR
Warnings99100
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

mahibi
mahibi approved these changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@mahibi mahibi merged commit c8cb8f9 into master Jan 8, 2026
17 of 21 checks passed
@mahibi mahibi deleted the style/noid/reactionRevamp branch January 8, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 rapterjet2004 approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyScherzinger @sowjanyakch @mahibi @rapterjet2004