Skip to content

Fixing edit view state #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapterjet2004 merged 1 commit into from
Jan 7, 2026
Merged

Fixing edit view state #5677

rapterjet2004 merged 1 commit into from
Jan 7, 2026
+20 −12

Conversation

@rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Dec 30, 2025 •
edited by AndyScherzinger
Loading

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Dec 30, 2025
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Dec 30, 2025
@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Dec 30, 2025
mahibi
mahibi approved these changes Jan 7, 2026
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.
needs to be adapted to the changes from bubbled message input..

@rapterjet2004
fixing edit view state after PR 5608
f5b9630 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5677.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Codacy

Lint

TypemasterPR
Warnings9997
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@rapterjet2004 rapterjet2004 merged commit 69b6a73 into master Jan 7, 2026
16 of 17 checks passed
@rapterjet2004 rapterjet2004 deleted the issue-5675-edit-ui branch January 7, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@rapterjet2004 rapterjet2004

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

Improper edit view state when exiting Voice Recording

4 participants

@rapterjet2004 @mahibi @AndyScherzinger