pathogen-repo-build: Support artifact-paths with AWS Batch#164
Open
pathogen-repo-build: Support artifact-paths with AWS Batch#164
Conversation
Without this, the workflow execution happens in the run-build job instead of the wait-N jobs.
victorlin
force-pushed
the
victorlin/artifact-paths
branch
from
6941e1a to
bfa71f3
Compare
This is now possible with the wait-N jobs.
victorlin
force-pushed
the
victorlin/artifact-paths
branch
from
bfa71f3 to
e716626
Compare
victorlin
changed the title
This allows the full build log to be uploaded upon completion, matching behavior in run-build with local runtimes.
joverlee521
reviewed
Mar 19, 2026
Comment on lines
+411
to
+418
| - if: ${{ always() && steps.attach.outputs.conclusion != 'timeout' }} | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| if-no-files-found: warn | ||
| name: ${{ inputs.artifact-name }} | ||
| path: | | ||
| ${{ env.NEXTSTRAIN_DEFAULT_ARTIFACT_PATHS }} | ||
| ${{ inputs.artifact-paths }} |
Contributor
There was a problem hiding this comment.
Hmm, I'm slightly worried about artifact storage limits, which I think is 2GB/repo/month?
The builds we run on AWS Batch are usually the larger builds so these might take up too much storage. I'd rather save the artifact storage space for GitHub Action workflows that are not on AWS since those outputs are not accessible outside for GitHub.
Maybe using artifacts should be an opt-in feature for AWS Batch instead of the default?
Member
Author
There was a problem hiding this comment.
Good call, I'll update this PR to make it opt-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is now possible with the wait-N jobs.
Should improve debugging experience for workflows using the AWS Batch runtime.
Checklist