Bind the development web port to localhost by default#31
Open
Torchbearer127 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the example development configuration bind the web port to localhost by default:
export DOCKER_WEB_PORT_FORWARD=127.0.0.1:8000It also adds a short note in
.env.exampleand the README explaining that Flask / Werkzeug debug tooling should not be exposed to untrusted networks.Why
The example
.envenablesFLASK_DEBUG=truefor local development. Before this change, copying.env.exampleand running the app published the web service on all host interfaces withDOCKER_WEB_PORT_FORWARD=8000.Binding to
127.0.0.1preserves the normal local browser workflow while reducing the chance that development-only debug tooling is reachable from a LAN, VM interface, or public dev host by accident.Closes #30.
Verification
bash -n .env.exampledocker compose --env-file .env.example config --services