mDNS parser: skip a 'Record' on parse error#39
Open
asashnov wants to merge 3 commits intonitroshare:masterfrom
Open
mDNS parser: skip a 'Record' on parse error#39asashnov wants to merge 3 commits intonitroshare:masterfrom
asashnov wants to merge 3 commits intonitroshare:masterfrom
Conversation
Skipping an unknown Record is much better then ignoring the entire Message.
Add a real-life UDP packed data captured from Python zeroconf module. The current 'master' (0ca8011) incorrectly determines the end of NSEC record, causing next 'A' record unparsed.
That will allow to skip unknown or incorrectly parsed records, and move one to a next record to the right place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping an unknown Record is much better then ignoring the entire Message.
I'm not sure what caused the parse error. Sometimes it happens, sometime don't, maybe somehow interfere with my local avahi server and used cache in code.
I dumped the example of such UDP payload (QByteArray packet dump):
mDNS_UDP_packet.zip
But whatever the reason of parse error, it makes sense to proceed with records which parsed successfully. Otherwise mDNS browser will not show anything.
Here was my research, comparsion 'offset' in qmdns parser and offset the same records in WireShark: