Fix handling of service names with dots#8
Open
cgutman wants to merge 1 commit intonitroshare:masterfrom
Open
Conversation
| { | ||
| // Split the FQDN into service name and type | ||
| int index = fqName.indexOf('.'); | ||
| int index = fqName.indexOf('_') - 1; |
Contributor
There was a problem hiding this comment.
perhaps this should be "._" (assume empty service names shouldn't be supported)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QMdnsEngine currently assumes service names will not contain dots. This causes it to mishandle mDNS responses for NVIDIA GameStream which contain several dots in the service name.
The following is an example of such a response:
_nvstream._tcp.local: type PTR, class IN, 3.14.0.161-WIN10-GS.765ebd34-e2e9-4502-8fdd-5e8ed485b667._nvstream._tcp.localThe current parsing logic results in
3being considered the service name, rather than3.14.0.161-WIN10-GS.765ebd34-e2e9-4502-8fdd-5e8ed485b667. Other mDNS implementations I've tried (jmDNS and NSNetServiceBrowser) return the expected service name.I updated the Browser unit test to exercise this fix.