Skip to content

[AIX] Define timespec_tv_nsec_t as 32-bit. #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amy-kwan wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Open

[AIX] Define timespec_tv_nsec_t as 32-bit. #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f52030
[AIX] Define timespec_tv_nsec_t as 32-bit.
amy-kwan Dec 12, 2025
5abf047
Add changelog.
amy-kwan Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ targets = [
]

[dependencies]
libc = { version = "=0.2.175", features = ["extra_traits"] }
libc = { version = "=0.2.178", features = ["extra_traits"] }
Copy link
Author

@amy-kwan amy-kwan Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of tv_nsec to 32-bit comes from libc 0.2.178, which we're using on AIX currently. However, I'm uncertain if this update is appropriate at this time for all targets.

Copy link
Member

@SteveLauC SteveLauC Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always fine to bump libc to a newer compatible version

bitflags = "2.3.3"
cfg-if = "1.0"
pin-utils = { version = "0.1.0", optional = true }
Expand Down
1 change: 1 addition & 0 deletions changelog/2714.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Define `timespec_tv_nsec_t` as 32-bit on both 32- and 64-bit AIX to match the platform ABI.
5 changes: 4 additions & 1 deletion src/sys/time.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,14 @@ const TS_MAX_SECONDS: i64 = isize::MAX as i64;

const TS_MIN_SECONDS: i64 = -TS_MAX_SECONDS;

// AIX: libc::timespec.tv_nsec is 32-bit c_int on both 32- and 64-bit.
#[cfg(target_os = "aix")]
type timespec_tv_nsec_t = libc::c_int;
// x32 compatibility
// See https://sourceware.org/bugzilla/show_bug.cgi?id=16437
#[cfg(all(target_arch = "x86_64", target_pointer_width = "32"))]
type timespec_tv_nsec_t = i64;
#[cfg(not(all(target_arch = "x86_64", target_pointer_width = "32")))]
#[cfg(not(any(target_os = "aix", all(target_arch = "x86_64", target_pointer_width = "32"))))]
type timespec_tv_nsec_t = libc::c_long;

impl From<timespec> for TimeSpec {
Expand Down
Loading