test: add missing parse-level tests for ignore_comment edge cases#5160
Open
shub-gour wants to merge 1 commit into
Open
test: add missing parse-level tests for ignore_comment edge cases#5160shub-gour wants to merge 1 commit into
shub-gour wants to merge 1 commit into
Conversation
Owner
|
These tests already exist. |
Author
|
Thanks for the feedback! I'll find a genuinely uncovered |
Author
|
Updated the PR — replaced the previous tests with genuinely |
nlohmann
reviewed
May 10, 2026
Owner
nlohmann
left a comment
nlohmann
left a comment
There was a problem hiding this comment.
Comments are ignored within the lexer, and this is covered by unit-class_lexer.cpp. You test the parser - this is not an edge case, but independent features.
Signed-off-by: Shubham <gour5888@gmail.com>
shub-gour
force-pushed
the
test/empty-array-regression
branch
from
c909985 to
cde2ee5
Compare
shub-gour
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing high-level parse tests for
ignore_commentedge cases (issue #2330).The existing test only covers consecutive
//comments before an empty object.These new sections cover:
//comment before an array/* */block comment before an objectignore_comment=falsecorrectly throws on comment inputNotes
Low-level lexer comment scanning is already tested in unit-class_lexer.cpp.
These tests cover the missing json::parse() level cases.