[Hotfix]: new section works when custom is FALSE#455
Conversation
Checklist
|
New version checklist
|
Code Metrics Report
Code coverage of files in pull request scope (38.7%)
Reported by octocov |
|
Woops, put my comment on the issue instead of the PR 😅 #452 (comment) |
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me! I mentioned a different error on the issue itself but understand if you'd prefer to make that a separate PR.
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
Thanks for working on this issue! Nearly everything looks good. However, when testing the example in the issue, it doesn't render because both of the new sections' code chunks have the same label: example_chunk_1. I think this will confuse users. One way to avoid duplicating labels would be to make the chunk label identical to the section name + 1, or to remove the code chunks from the new sections entirely.
|
@sbreitbart-NOAA oh good call! I'll remove them entirely because they shouldn't be needed. |
|
@sbreitbart-NOAA the issue should be fixed now. I'll merge this in after dev and push this to v1.0 branch as a hotfix as well. |
…older and don't sort
7d6505d to
d4bf83f
Compare
What is the feature?
How have you implemented the solution?
create_templatethat overwrites custom to FALSE when the user setsnew_sectionorcustom_sectionsand forgets to set custom = TRUEDoes the PR impact any other area of the project, maybe another repo?