[single] Refactor: Replace busy waiting with a condition variable in close #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songgot
requested review from
again4you,
anyj0527,
gichan-jang,
jaeyun-jung and
myungjoo
as code owners
songgot
force-pushed
the
remove_g_usleep
branch
3 times, most recently
from
71fbff2 to
fa75cbf
Compare
jaeyun-jung
reviewed
Nov 27, 2025
…close Replaced the busy waiting loop (g_usleep) in ml_single_close with `g_cond_wait` to improve CPU efficiency. - Modified to broadcast a signal immediately after completing an invoke tasek. - Updated to wait on the condition variable instead of polling the `invoking` state every 1ms. Signed-off-by: hyunil park <hyunil46.park@samsung.com>
songgot
force-pushed
the
remove_g_usleep
branch
from
fa75cbf to
a693cd5
Compare
myungjoo
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the busy waiting loop (g_usleep) in ml_single_close with
g_cond_waitto improve CPU efficiency.invokingstate every 1ms.