Issue/1571 account recovery when email address includes +#1860
Open
SarthakDudhe wants to merge 2 commits intonodeSolidServer:mainfrom
Open
Issue/1571 account recovery when email address includes +#1860SarthakDudhe wants to merge 2 commits intonodeSolidServer:mainfrom
+#1860SarthakDudhe wants to merge 2 commits intonodeSolidServer:mainfrom
Conversation
TallTed
changed the title
+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on #1571: “If you sign up with a plus sign in your email, your account can't be used or recovered” on branch
issue/1571-plus-email-recovery.The safest concrete fix here is in the
recovery-emailpath. NSS writes the account recovery email intomailto:IRIs in account templates, then reads it back out of the root ACL during password reset. I updatedaccount-template.mjsto encode the local part of mailbox addresses formailto:usage, sojon+solidtest@snap.comis stored asjon%2Bsolidtest@snap.com. I also updatedaccount-manager.mjsto decode the storedmailto:value back to the original email when loading the recovery address.I added focused unit coverage in
account-template-test.mjsandaccount-manager-test.mjsfor the exact+case from the issue.npx mocha test/unit/account-template-test.mjs test/unit/account-manager-test.mjspasses with 39 passing.npm run lintalso passes, with the same pre-existing unrelated warning intest/integration/params-test.mjs.