Migrate to Express v5#1863
Open
SarthakDudhe wants to merge 1 commit intonodeSolidServer:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved #1811 on branch issue/1811-express-v5.
I upgraded Express from ^4.22.1 to ^5.2.1 in package.json and package-lock.json, then fixed Express 5 route compatibility in:
lib/create-app.mjs
lib/create-server.mjs
lib/handlers/auth-proxy.mjs
lib/ldp-middleware.mjs
Verification:
npm run lint passes with 1 existing warning
npm run validate passes
npm run test-unit passes: 311 passing
npm run mocha-integration passes: 116 passing
npm test still fails on local DNS/hosts setup for tim.localhost, nic.localhost, nicola.localhost