build: disable jenkins reload after backup/clearup#4268
Open
sxa wants to merge 2 commits intonodejs:mainfrom
Open
build: disable jenkins reload after backup/clearup#4268sxa wants to merge 2 commits intonodejs:mainfrom
sxa wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
richardlau
reviewed
Mar 9, 2026
backup/backup_scripts/remove_old.sh
Outdated
| CREDENTIALS=$(</root/.jenkins_credentials) | ||
| ssh -i /root/.ssh/nodejs_build_backup $HOST find "$ROOTDIR" -depth -type d -regex "$REGEX" -mtime +$DAYS -exec "rm -rf '{}' \;" | ||
| ssh -i /root/.ssh/nodejs_build_backup $HOST find "$ROOTDIR" -depth -type d -regex "$REGEX" -mtime +$DAYS -exec "rm -rvf '{}' \;" | ||
| JENKINS_CRUMB=$(curl -sL --user "$CREDENTIALS" https://$HOST/'crumbIssuer/api/xml?xpath=concat(//crumbRequestField,":",//crumb)') |
Member
There was a problem hiding this comment.
This isn't used if we're no longer calling the REST API to reload.
Member
Author
There was a problem hiding this comment.
Fair - commented out that line too now.
Signed-off-by: Stewart X Addison <sxa@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is potentially a temporary fix until we get the upstream jenkins fix for #4247 but I'm not sure the reload is strictly needed. Note that this change has been made on the backup system so is already live, but won't kick in until it runs next weekend.
This PR also adds
-vto thermcommand (GNU-specific, but our backup server is Linux) with the intention of having a log of what files are deleted in case it's useful in debugging anything.To support such debugging I've also modified the crontab on the backup server to
teethe output of the script to/root/backup_scripts/remote_old.sh.{testci,releaseci}.log. This could be compressed if anyone would prefer it that way. Logs are not retained once the next run kicks in.