Skip to content

Conversation

@btea
Copy link
Contributor

@btea btea commented Jan 7, 2026

Description

Synchronize with the old version of the document.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings January 7, 2026 05:05
@btea btea requested a review from a team as a code owner January 7, 2026 05:05
@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
api-docs-tooling Ready Ready Preview Jan 7, 2026 5:19am

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.95%. Comparing base (da9f66a) to head (a4edfbc).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   79.95%   79.95%           
=======================================
  Files         127      127           
  Lines       12285    12285           
  Branches      866      866           
=======================================
  Hits         9823     9823           
  Misses       2459     2459           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds automatic scrolling functionality to bring the active sidebar link into view when a documentation page loads. The implementation synchronizes the web generator with similar functionality that exists in the legacy HTML generator.

  • Introduces a new bootstrap.js file that handles sidebar scroll behavior
  • Integrates the bootstrap script into the HTML template
  • Uses smooth scrolling to center the active page link in the sidebar

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/generators/web/bootstrap.js New client-side script that implements the sidebar auto-scroll functionality by finding the active link and scrolling it into view
src/generators/web/template.html Adds script tag to load the new bootstrap.js file in the page head

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @btea doc-kit isn't the place where this should be fixed. The fix should be done on @node-core/ui-components and there's already an open PR there: nodejs/nodejs.org#8517

@btea
Copy link
Contributor Author

btea commented Jan 7, 2026

I'm sorry, thank you for your guidance.

@btea btea closed this Jan 7, 2026
@ovflowd
Copy link
Member

ovflowd commented Jan 7, 2026

I'm sorry, thank you for your guidance.

No need to apologize!! I absolutely appreciate your investment here ❤️

@btea btea deleted the feat/sidebar-active-link-scroll-into-view branch January 7, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants