-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
src: add HandleScope to loop in heap_utils #60885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
mertcanaltin:mert/add-handle-scope/heap-utils
Dec 27, 2025
Merged
src: add HandleScope to loop in heap_utils #60885
nodejs-github-bot
merged 1 commit into
nodejs:main
from
mertcanaltin:mert/add-handle-scope/heap-utils
Dec 27, 2025
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60885 +/- ##
=======================================
Coverage 88.55% 88.56%
=======================================
Files 703 703
Lines 208291 208293 +2
Branches 40174 40169 -5
=======================================
+ Hits 184454 184470 +16
- Misses 15829 15837 +8
+ Partials 8008 7986 -22
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Nov 28, 2025
fb6528f to
d856e98
Compare
d856e98 to
d09922c
Compare
juanarbol
approved these changes
Nov 30, 2025
Flarna
approved these changes
Dec 3, 2025
Member
Author
|
I think this pr ready for merge? |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
Collaborator
|
Landed in 7786470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added HandleScope to loop in heap_utils