Skip to content

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Dec 25, 2025

Add missing CHECK in FastCRC32 to match the slow path.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Dec 25, 2025
@mcollina mcollina marked this pull request as ready for review December 25, 2025 23:36
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (4f24aff) to head (c2aaa42).
⚠️ Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
src/node_zlib.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61175   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         703      703           
  Lines      208546   208599   +53     
  Branches    40217    40231   +14     
=======================================
+ Hits       184634   184690   +56     
+ Misses      15926    15911   -15     
- Partials     7986     7998   +12     
Files with missing lines Coverage Δ
src/node_zlib.cc 77.79% <0.00%> (-0.08%) ⬇️

... and 60 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2025
@nodejs-github-bot
Copy link
Collaborator

@mcollina mcollina force-pushed the fix-zlib-crc32-fast-path-validation branch from 958ba9c to c2aaa42 Compare December 27, 2025 15:19
@mcollina mcollina changed the title zlib: fix input validation in crc32 fast path zlib: add CHECK to validate fast path input Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants