-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(downloads): remove devbox #8527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8527 +/- ##
==========================================
+ Coverage 74.69% 74.83% +0.13%
==========================================
Files 102 101 -1
Lines 8956 8924 -32
Branches 305 304 -1
==========================================
- Hits 6690 6678 -12
+ Misses 2264 2244 -20
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes DevBox as an installation method from the Node.js website because DevBox does not meet the project's FOSS (Free and Open Source Software) guidelines.
Key changes:
- Removed DevBox icon component and all references from UI components
- Removed 'DEVBOX' from the InstallationMethod type definition
- Deleted DevBox installation snippets across all 13 supported languages
- Removed DevBox localization strings from all applicable language files
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/Icons/InstallationMethod/index.ts | Removed DevBox import and export from installation method icons |
| packages/ui-components/src/Icons/InstallationMethod/Devbox.tsx | Deleted DevBox icon component |
| packages/ui-components/design/platform-logos.stories.tsx | Removed DevBox from Storybook stories |
| apps/site/types/release.ts | Removed 'DEVBOX' from InstallationMethod type union |
| apps/site/util/download/constants.json | Removed DevBox configuration entry from installMethods array |
| packages/i18n/src/locales/*.json | Removed DevBox description from 11 language files (en, fr, id, ja, ko, pt, pt-br, ro, uk, zh-cn, zh-tw) |
| apps/site/snippets/*/download/devbox.bash | Deleted DevBox installation snippets for 13 languages (en, es, fr, id, ja, ko, pt, pt-br, ro, tr, uk, zh-cn, zh-tw) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (4)
➖ Removed Assets (4)
|
araujogui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #8525.
DevBox does not meet our guidelines, as it is not a FOSS product.